Skip to content

fix(node): Include system message in anthropic-ai messages span - #18332

Merged
isaacs merged 1 commit into
developfrom
isaacs/js-1223-include-anthropic-system-message
Dec 3, 2025
Merged

fix(node): Include system message in anthropic-ai messages span#18332
isaacs merged 1 commit into
developfrom
isaacs/js-1223-include-anthropic-system-message

Conversation

@isaacs

@isaacs isaacs commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #18331

Closes #18365

@isaacs
isaacs requested a review from RulaKhaled November 25, 2025 18:52
@linear

linear Bot commented Nov 25, 2025

Copy link
Copy Markdown

JS-1223 JS Anthropic AI SDK - gen_ai.request.messages attribute incomplete

@github-actions

github-actions Bot commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.8 kB - -
@sentry/browser - with treeshaking flags 23.31 kB - -
@sentry/browser (incl. Tracing) 41.54 kB - -
@sentry/browser (incl. Tracing, Profiling) 46.13 kB - -
@sentry/browser (incl. Tracing, Replay) 79.96 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.68 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84.64 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 96.88 kB - -
@sentry/browser (incl. Feedback) 41.48 kB - -
@sentry/browser (incl. sendFeedback) 29.49 kB - -
@sentry/browser (incl. FeedbackAsync) 34.47 kB - -
@sentry/react 26.52 kB - -
@sentry/react (incl. Tracing) 43.74 kB - -
@sentry/vue 29.25 kB - -
@sentry/vue (incl. Tracing) 43.34 kB - -
@sentry/svelte 24.82 kB - -
CDN Bundle 27.21 kB - -
CDN Bundle (incl. Tracing) 42.21 kB - -
CDN Bundle (incl. Tracing, Replay) 78.75 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 84.2 kB - -
CDN Bundle - uncompressed 79.96 kB - -
CDN Bundle (incl. Tracing) - uncompressed 125.34 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 241.37 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.13 kB - -
@sentry/nextjs (client) 45.96 kB - -
@sentry/sveltekit (client) 41.9 kB - -
@sentry/node-core 51.27 kB +0.01% +1 B 🔺
@sentry/node 159.53 kB +0.06% +86 B 🔺
@sentry/node - without tracing 92.85 kB - -
@sentry/aws-serverless 108.14 kB - -

View base workflow run

@github-actions

github-actions Bot commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,807 - 9,041 -3%
GET With Sentry 1,726 20% 1,702 +1%
GET With Sentry (error only) 6,111 69% 6,066 +1%
POST Baseline 1,202 - 1,175 +2%
POST With Sentry 595 50% 571 +4%
POST With Sentry (error only) 1,074 89% 1,021 +5%
MYSQL Baseline 3,402 - 3,261 +4%
MYSQL With Sentry 486 14% 431 +13%
MYSQL With Sentry (error only) 2,764 81% 2,664 +4%

View base workflow run

isaacs added a commit that referenced this pull request Nov 26, 2025
@isaacs
fix(node): Include system message in anthropic-ai messages span (#18332)
1b0d784 
Fixes JS-1223
Fixes GH-18331
@isaacs
isaacs force-pushed the isaacs/js-1223-include-anthropic-system-message branch from de0a4f9 to 1b0d784 Compare November 26, 2025 06:32
RulaKhaled
RulaKhaled reviewed Nov 27, 2025
View reviewed changes

@RulaKhaled RulaKhaled left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Can you please add a description to the issue you're working on? it would be super helpful to see one before diving into the review 🙏

Also, node integration tests are failing, we need to update test expectations to include the new system prompts. Thanks!

Comment thread packages/core/src/tracing/anthropic-ai/utils.ts Resolved
Comment thread packages/core/src/tracing/anthropic-ai/index.ts Resolved
isaacs added a commit that referenced this pull request Dec 1, 2025
@isaacs
fix(node): Include system message in anthropic-ai messages span (#18332)
2318648 
Fixes JS-1223
Fixes GH-18331
isaacs added a commit that referenced this pull request Dec 1, 2025
@isaacs
fixup! fix(node): Include system message in anthropic-ai messages span (
65d6be5 
#18332)
@isaacs
isaacs force-pushed the isaacs/js-1223-include-anthropic-system-message branch from 1b0d784 to 65d6be5 Compare December 1, 2025 22:17
@github-actions github-actions Bot mentioned this pull request Dec 1, 2025
Closed
2 tasks done
RulaKhaled
RulaKhaled approved these changes Dec 2, 2025
View reviewed changes

@RulaKhaled RulaKhaled left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes

isaacs added a commit that referenced this pull request Dec 3, 2025
@isaacs
fix(node): Include system message in anthropic-ai messages span (#18332)
a606a21 
Fixes JS-1223
Fixes GH-18331
@isaacs
isaacs force-pushed the isaacs/js-1223-include-anthropic-system-message branch from 65d6be5 to a606a21 Compare December 3, 2025 00:05
isaacs added a commit that referenced this pull request Dec 3, 2025
@isaacs
fix(node): Include system message in anthropic-ai messages span (#18332)
ad5a87a 
Fixes JS-1223
Fixes GH-18331
@isaacs
isaacs force-pushed the isaacs/js-1223-include-anthropic-system-message branch from a606a21 to ad5a87a Compare December 3, 2025 15:03
@isaacs
isaacs force-pushed the isaacs/js-1223-include-anthropic-system-message branch from ad5a87a to 0ceea43 Compare December 3, 2025 15:49
@isaacs
isaacs merged commit b6eb205 into develop Dec 3, 2025
206 checks passed
@isaacs
isaacs deleted the isaacs/js-1223-include-anthropic-system-message branch December 3, 2025 17:52
@github-actions github-actions Bot mentioned this pull request Dec 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RulaKhaled RulaKhaled RulaKhaled approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(node): Include system message in anthropic-ai messages span JS Anthropic AI SDK - gen_ai.request.messages attribute incomplete

2 participants

@isaacs @RulaKhaled